Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install gpu requirements in tox config #1005

Closed
wants to merge 1 commit into from
Closed

Install gpu requirements in tox config #1005

wants to merge 1 commit into from

Conversation

oliverholworthy
Copy link
Member

Goals ⚽

Run GPU tests with cudf and transformers

Implementation Details 🚧

Adding gpu requirements to gpu.txt and installing all requirements inside py38-gpu tox env

Testing Details 🔍

  • Check that GPU test runner doesn't skip any tests

@oliverholworthy oliverholworthy self-assigned this Feb 28, 2023
@oliverholworthy oliverholworthy added this to the Merlin 23.03 milestone Feb 28, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1005

@oliverholworthy
Copy link
Member Author

This was an alternative to setting sitepackages=True in our tox config. We may wish to revisit this option in future if sitepackages turns out to be an issue.

Closing this in favour of setting sitepackages in #1011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oliverholworthy oliverholworthy

Labels
ci
Projects
None yet
Milestone
Merlin 23.03
Development

Successfully merging this pull request may close these issues.
1 participant
@oliverholworthy